search

kristianmandrup / aurelia-rethink-bindtable

Aurelia bind table integration for RethinkDB via Socket.io
16 stars 2 forks source link

fixing promise issue #2

Closed pablogq closed 9 years ago

pablogq commented 9 years ago

The problem was the arguments of the callback that you must provide to the Promise constructor was backwards.

The first argument is the resolve function and the second the reject function. In the code was first reject and second resolve.

Now the three tests are green :)

The diff ui of github will display a lot of changes, this is due my text editor right trims the document lines when I save it.

kristianmandrup commented 9 years ago

Awesome! Was because I reused the original code which was in this order :P

kristianmandrup commented 9 years ago

Yiiihaaaa :) So excited!!!