Closed bhubr closed 6 years ago
Great! Thank you so much! I never got around to testing it fully, so thanks for catching these bugs. Feel free to submit more PRs in the future as you dive deeper. Also feel to suggest and submit PRs with API improvements. Cheers!
You're welcome! Thanks for merging. I'll let you know if I get into other issues, if I use more features in my project. Cheers!
I tried to used the lib, and had an error when doing things such as:
The error I got was:
It came from two things:
validateArgs
function slices theargs
it receives. Apparently, doing it on an empty array doesn't work, but callingArray.prototype.slice
does.validateArgs
fromrepositories.get
, the order ofarguments
and the number of expected arguments was swapped.So I felt free to submit this PR fixing both things. I had issues with running
npm test
though (Unexpected token import
... meaning that sources were notbabel
ified when running tests?).