search

kristianmandrup / geo-distance

Calculates the geo distance between two locations using longitude and latitude, using Haversine, Speherical or Vincenty formula
MIT License
52 stars 19 forks source link

Broken #5

Open ykessler opened 7 years ago

ykessler commented 7 years ago

Totally broken- not even the examples work.

kristianmandrup commented 7 years ago

I'm sorry. Haven't touched this for like 5 years? You are welcome to have a look and see where it is broken and try fix it. It was originally a port of some JS code/library I found.

ykessler commented 7 years ago

Understood but then you should have a disclaimer in the README that this is not working and unmaintained. People waste their time time trying to use this, thinking it's a valid library- only to discover it's broken.

kristianmandrup commented 7 years ago

I will try to fix it this week ;)

markwilkinson commented 6 years ago

I got one message complaining about Fixnum in: geo-distance/lib/geo-distance/core_ext.rb Never got that message again, though.

Anyway, that might be the source of your problem. I'm a ruby noob, so I wont be able to help debug :-)

I hope you find a solution! (or remove it from rubygems entirely... this is the third geo-ip package I have tried, and all of them are broken so far :-/ )

Mark

kristianmandrup commented 6 years ago

I made some fixes, but would require 4-8 hrs extensive debugging + new tests to make it fully functional again... I will see if I can find the time later this week.