kristianmandrup / gmaps-autocomplete-rails

Google Maps v3 search with jQuery UI Autocomplete, ready for use with Rails asset pipeline
MIT License
73 stars 35 forks source link

Gem not working with latest gem versions #21

Open Startouf opened 8 years ago

Startouf commented 8 years ago

After a gem update through bundle update, the autocomplete stopped working. I have upgraded from 0.1.4 to 2.0.0

Any upgrade guide available ? The homepage only mentions the 1.2.0 -> 1.3.0 migration.

I don't have any error in the JS (I believe) but the <ul> tag with autocomplete results doesn't get populated

JS debug output

called with opts Object { inputField="#company_employee_meeting_place",  pos=[2],  errorField="#company_employee_meeting_place_errors",  more...}
gmaps-a...d415.js (line 120)
final completerAssist undefined
gmaps-a...d415.js (line 120)
defaultOptions Object { mapElem="#gmaps-canvas",  zoomLevel=2,  mapType="roadmap",  more...}
gmaps-a...d415.js (line 120)
options after merge with defaults Object { mapElem="#map",  zoomLevel=14,  mapType="roadmap",  more...}
gmaps-a...d415.js (line 120)
lat,lng (44.620909, 4.389862999999991) { lat=function(),  lng=function(),  toString=function(),  more...}
gmaps-a...d415.js (line 120)
map options Object { zoom=14,  center=(44.620909, 4.389862999999991),  mapTypeId="roadmap",  more...}
gmaps-a...d415.js (line 120)
mapElem <div id="map" class="col-xs-8">
gmaps-a...d415.js (line 120)
region undefined
kristianmandrup commented 8 years ago

I recommend rewriting the gem from scratch reusing parts that make sense in modern dev environment...

kristianmandrup commented 8 years ago

I haven't been on Rails since around 2012-13. So someone else please continue this gem ;)

kristianmandrup commented 8 years ago

Why anyone would use Rails to render views and use the asset pipeline in 2015+ is beyond me tbh. So many better alternatives... Try Vue2 ;)

Startouf commented 8 years ago

The 2.0 commits afre from around 2 months ago. It's not that long.

kristianmandrup commented 8 years ago

Must have been some PR I merged from someone else, I don't anything about Rails changes since 4.0 came out.