search

kristianmandrup / schema-to-yup

Schema to Yup validation
Other
283 stars 50 forks source link

Bundle error #103

Closed jacky158 closed 2 years ago

jacky158 commented 2 years ago

Try bundlephobia with schema to yup

https://bundlephobia.com/package/schema-to-yup

leonbloy commented 2 years ago

I have the same error when I try to build my React app with CRA 3.4 : it seems that Webpack 4 does not understand the nullish coalescing :

hasDateFormat: (obj) => ["date", "date-time"].includes(obj?.value?.format)

kristianmandrup commented 2 years ago

Please let's work together to solve this issue. I have more time at the moment.

kristianmandrup commented 2 years ago

I'm fixing the nullish coalescing issue now. Someone from the community added that part.

kristianmandrup commented 2 years ago

@screw123 Should be fixed with latest push to master. Try it out. If it works for you, I will do a new release with this patch

kristianmandrup commented 2 years ago

I published 1.11.7 which should hopefully fix it

omiq17 commented 2 years ago

Yes, the issue got fixed with 1.11.7. Thanks.

kristianmandrup commented 2 years ago

Awesome! Very happy to hear that :) Please try out the new array type implementation fix. Also feel free to make PRs to improve the library or come with suggestions for improvements or missing features.