kristianolesenlarsen / sdseml_online_exercises

Online exercise classes for the course "Social Data Science: Econometrics and Machine Learning"
11 stars 39 forks source link

Feedback Ex12: #33 #523

Open kristianolesenlarsen opened 4 years ago

kristianolesenlarsen commented 4 years ago

@s-honore (please reply to this issue when you have read your feedback)

The warmup Looks super!

The exercises Looks ok. I dont understand why you use both df2 and df. It likely messes up your results (look at your first figure, you color the dots by the same variable that you have on the x-axis, yet the colors are random).

Score: 1 sorry your feedback is a bit brief this time