search

kristianserrano / swade-item-tables-issue-tracker

Report an issue with the SWADE Item Tables module for Foundry VTT
0 stars 0 forks source link

Bug: Only the first Skill, Hindrance etc. can be deleted #4

Closed mhilbrunner closed 2 months ago

mhilbrunner commented 2 months ago

If I add multiple skills, hindrances etc., only the first one can be deleted. I can delete all, one after the other, but can't delete e.g. the last one before I have deleted all others.

I attached an exported actor that was freshly created. For example, it had two skills added (excuse the german): "Fahrzeug" (vehicle) and "Fokus" (focus). I can delete the former, but pressing delete on the latter does not work until I deleted the former.

fvtt-Actor-test-akEJjdv6zjz7ISdV.zip

kristianserrano commented 2 months ago

I found the issue. I was using querySelector and adding the event listener to just one instance of the delete buttons instead of querySelectorAll and looping to add the event listeners to all of them. Honestly, I don't know how this hasn't come up sooner. Rolling out a fix soon.

kristianserrano commented 2 months ago

Fixed and released v1.15.7!

mhilbrunner commented 2 months ago

Thank you, that was amazingly quick, and thanks for the awesome module 🙏

kristianserrano commented 2 months ago

You're absolutely welcome, and thank you!

By the way, dropped a comment regarding submitting items 1 and 2 regarding localization. Basically, if you can create an issue for each, I'd appreciate it.