kristijanhusak / laravel-form-builder

Laravel Form builder for version 5+!

https://packagist.org/packages/kris/laravel-form-builder

MIT License

1.7k stars 298 forks source link

Revert #725 - Registering customLabel macro once Form resolved #726

Closed sangnguyenplus closed 5 months ago

sangnguyenplus commented 6 months ago

725

@rudiedirkx It is working fine in our latest code with Laravel 10, but I got some reports that it doesn't work for old versions (which using Laravel 9).

I think this is a breaking change, we should not change this at this time.

Please revert it.

rudiedirkx commented 6 months ago

Works for me with Laravel 9 on PHP 8.2. Original PR tested Laravel 9 on PHP 8.0, that worked too: https://github.com/kristijanhusak/laravel-form-builder/actions/runs/8547107396/job/23418677886?pr=725

What seems to be going wrong? Any idea? I like the smarter boot, I don't want to revert it without a good specific known reason.

sangnguyenplus commented 6 months ago

@rudiedirkx I have no idea, if it is fine for you then we may keep it. Maybe it has something wrong with their code, not an issue of this package.

rudiedirkx commented 6 months ago

If you get more details or reports, add them here. Maybe our tests just aren't good enough, but the afterResolving change seems good to me.

rudiedirkx commented 5 months ago

@sangnguyenplus 1.53.1 probably fixes this.