search

kristijanhusak / vim-dadbod-ui

Simple UI for https://github.com/tpope/vim-dadbod
MIT License
1.54k stars 94 forks source link

Cursorline and default mappings #217

Closed seblj closed 10 months ago

seblj commented 10 months ago

Hi :) I have a couple of things that I find a bit annoying. I personally do not use the setting cursorline. I see that it is set by default for the buffers created by this plugin. Also, some of the default mappings conflict with my personal mappings that I use all the time. I think I personally would prefer to not override any user configured mappings. Currently I have to disable all default mappings, and the manually set everything except for the two mappings that I don't want this plugin to override. What do you think?

Really like it otherwise! Great plugin!

seblj commented 10 months ago

Ok, I see now that I can map the things I don't want to something else, then the mapping won't be applied and override my personal mappings. I think that is perfectly fine, because maybe sometimes it makes sense to override some other mappings for this plugin in the buffer.

However, I would still like the cursorline option to be removed. I would be willing to fix it myself if you would accept it of course :)

seblj commented 10 months ago

I just created a PR that removes the option :)