kristijanhusak / vim-dadbod-ui

Simple UI for https://github.com/tpope/vim-dadbod
MIT License
1.54k stars 94 forks source link

fix: stop overriding `list` in query files #269

Open ss-raicangu opened 3 months ago

ss-raicangu commented 3 months ago

Concerns

Description

Resolves #267.

commit 296374af294d41a2ea15017adb9c2ee146ee5f6c
Author: ss-raicangu <ssCm181126@outlook.com>
Date:   2024-08-07T23:07:24+12:00

    refactor: set `filetype` after other options

    This allows filetype plugins, such as `mysql.vim`, to override any of
    the special query buffer settings if needed.

    A similar pattern of setting `filetype` before other settings is present
    for the DBUI drawer. I assume this is more deliberate, and is out of
    scope for kristijanhusak/vim-dadbod-ui#267, so I haven't changed this
    part.

    This change was not signed off, so might be reverted.

    BREAKING-CHANGE: Options set in filetype plugins are now preferred for
                     query buffers.
    Link: https://github.com/kristijanhusak/vim-dadbod-ui/blob/0f51d8de368c8c6220973e8acd156d17da746f4c/autoload/db_ui/drawer.vim?plain=1#L38

commit 607d1c17bf5245553e7b20a277c951f664acaf92
Author: ss-raicangu <ssCm181126@outlook.com>
Date:   2024-08-07T22:57:22+12:00

    fix: stop overriding `list` in query files

    Problem: `list`-mode characters are not being shown in `dadbod-ui` query
             buffers and the filetype plugin setting is always being
             overridden.
    Solution: Remove `nolist` after `setlocal filetype`, so that the `list`
              preference is honoured.
    Signed-off-by: Kristijan Husak <husakkristijan@gmail.com>