kristijanhusak / vim-dadbod-ui

Simple UI for https://github.com/tpope/vim-dadbod
MIT License
1.54k stars 94 forks source link

fix(notification): swap notifications info colours #289

Open padulkemid opened 6 hours ago

padulkemid commented 6 hours ago

background

recently I fallback my colorscheme into the default colorscheme and decided to not use any syntax highlighting (but this shouldn't be the case) because I think the hl tag only respects from colorscheme rather than syntax, but what I found interesting is in the setup_colors() function in which we add a default color for the notification.

in my case the bg and fg were overlapped and the notification only shows full black, and after swapping the hl for NotificationInfo it works with displaying the guifg (because in the default colorscheme, i think only guibg are declared).

here are some comparison with different "default" colorscheme...

before the swap

Screenshot 2024-11-22 at 05 26 46 Screenshot 2024-11-22 at 05 34 16

after the swap

Screenshot 2024-11-22 at 05 25 42 Screenshot 2024-11-22 at 05 33 38

steps to reproduce

  1. change to default colorscheme (black background) or only have a guibg hl set
  2. run query