kristinbranson / APT

Animal Part Tracker
GNU General Public License v3.0
71 stars 16 forks source link

legacy file detection in loadLbl.m no longer working #412

Closed stephenhuston closed 11 months ago

stephenhuston commented 11 months ago

Hi,

loadLbl.m used to detect old .lbl files that were not tarred and just load them in raw .mat format (code snippet from line 5 of loadLbl.m copied below). This is no longer working in Matlab 2023a. I'm guessing it is because the error identifier thrown when attempting to untar non-tarred files has changed i.e. if strcmp(ME.identifier,'MATLAB:untar:invalidTarFile') no longer catches the error.

Thanks!

try fprintf('Untarring project into %s\n',tname); rawLblFile = fullfile(tname,'label_file.lbl'); untar(lbl_file,tname); fprintf('... done with untar.\n'); catch ME if strcmp(ME.identifier,'MATLAB:untar:invalidTarFile') warningNoTrace('Label file %s is not bundled. Using it in raw (mat) format.',lbl_file); rawLblFile = lbl_file; else ME.rethrow(); end end

adamltaylor commented 11 months ago

This appears to be fixed in the latest respective commits to the develop and multianimal branches. What branch/commit are you using?

stephenhuston commented 11 months ago

Thanks,

It is probably because I'm on a weird branch: stephen_working, latest commit.

Stephen

On Thu, Jul 13, 2023 at 4:32 PM Adam L. Taylor @.***> wrote:

This appears to be fixed in the latest respective commits to the develop and multianimal branches. What branch/commit are you using?

— Reply to this email directly, view it on GitHub https://github.com/kristinbranson/APT/issues/412#issuecomment-1634872033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6BISRPJTH3NTSBHCN3WTTXQBLPRANCNFSM6AAAAAA2GLDNKI . You are receiving this because you authored the thread.Message ID: @.***>

adamltaylor commented 11 months ago

OK. I'm sure you know this, but you might copy loadLbl.m from either of those branches into yours. I'm going to close this issue, but feel free to reopen if you think this is premature.