search

kristinemlarson / gnssrefl

GNSS Interferometric Reflectometry Software (GNSS-IR)
GNU General Public License v3.0
156 stars 76 forks source link

nmea2snr signal id sorting bug fix #188

Closed naoyakadota closed 1 year ago

naoyakadota commented 1 year ago

Hello,

I noticed that there's a bug in the nmea2snr module where the signal ID was not processed correctly and all SNR values from different signals were stored in the L1 column of the SNR file. Seems like this is due to a 'return' inserted in row 190, blocking further processing of the 'NMEA2SNR' function. Would be appreciated if you could have a look! - Naoya

kristinemlarson commented 1 year ago

Yes, I will give a look. Can you send me A NMEA file for testing?

On Mon, Sep 11, 2023 at 8:30 AM Naoya Kadota @.***> wrote:

Hello,

I noticed that there's a bug in the nmea2snr module where the signal ID was not processed correctly and all SNR values from different signals were stored in the L1 column of the SNR file. Seems like this is due to a 'return' inserted in row 190, blocking further processing of the 'NMEA2SNR' function. Would be appreciated if you could have a look! - Naoya

You can view, comment on, or merge this pull request online at:

https://github.com/kristinemlarson/gnssrefl/pull/188 Commit Summary

File Changes

(1 file https://github.com/kristinemlarson/gnssrefl/pull/188/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kristinemlarson/gnssrefl/pull/188, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSDAPDEE4GYD6JYAK25TDDXZ2VYTANCNFSM6AAAAAA4SZUBYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

naoyakadota commented 1 year ago

elr21400.23.A.zip Site name: elr2 Year: 2023 DoY: 140

Hope that works.

kristinemlarson commented 1 year ago

i need a lat/lon/ht to run nmea2snr. pls send.

On Mon, Sep 11, 2023 at 8:34 AM Naoya Kadota @.***> wrote:

elr21400.23.A.zip https://github.com/kristinemlarson/gnssrefl/files/12572861/elr21400.23.A.zip Site name: elr2 Year: 2023 DoY: 140

Hope that works.

— Reply to this email directly, view it on GitHub https://github.com/kristinemlarson/gnssrefl/pull/188#issuecomment-1713252497, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSDAPCI7UPCM7UVOAZIHW3XZ2WGTANCNFSM6AAAAAA4SZUBYQ . You are receiving this because you commented.Message ID: @.***>

-- Kristine M. Larson Professor Emerita, University of Bonn @.*** https://www.kristinelarson.net http://www.kristinelarson.net https://gnss-reflections.org https://github.com/kristinemlarson

Are you waiting for your code to be perfect?

kristinemlarson commented 1 year ago

i am not so familiar with NMEA. do you have signals other than l1? (glonass, galileo, gps etc)

On Mon, Sep 11, 2023 at 8:30 AM Naoya Kadota @.***> wrote:

Hello,

I noticed that there's a bug in the nmea2snr module where the signal ID was not processed correctly and all SNR values from different signals were stored in the L1 column of the SNR file. Seems like this is due to a 'return' inserted in row 190, blocking further processing of the 'NMEA2SNR' function. Would be appreciated if you could have a look! - Naoya

You can view, comment on, or merge this pull request online at:

https://github.com/kristinemlarson/gnssrefl/pull/188 Commit Summary

File Changes

(1 file https://github.com/kristinemlarson/gnssrefl/pull/188/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kristinemlarson/gnssrefl/pull/188, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSDAPDEE4GYD6JYAK25TDDXZ2VYTANCNFSM6AAAAAA4SZUBYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Kristine M. Larson Professor Emerita, University of Bonn @.*** https://www.kristinelarson.net http://www.kristinelarson.net https://gnss-reflections.org https://github.com/kristinemlarson

Are you waiting for your code to be perfect?

kristinemlarson commented 1 year ago

i updated the code for better orbits, but i did not write the main code at all.

On Mon, Sep 11, 2023 at 11:03 AM Kristine Larson @.***> wrote:

i am not so familiar with NMEA. do you have signals other than l1? (glonass, galileo, gps etc)

On Mon, Sep 11, 2023 at 8:30 AM Naoya Kadota @.***> wrote:

Hello,

I noticed that there's a bug in the nmea2snr module where the signal ID was not processed correctly and all SNR values from different signals were stored in the L1 column of the SNR file. Seems like this is due to a 'return' inserted in row 190, blocking further processing of the 'NMEA2SNR' function. Would be appreciated if you could have a look! - Naoya

You can view, comment on, or merge this pull request online at:

https://github.com/kristinemlarson/gnssrefl/pull/188 Commit Summary

File Changes

(1 file https://github.com/kristinemlarson/gnssrefl/pull/188/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kristinemlarson/gnssrefl/pull/188, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSDAPDEE4GYD6JYAK25TDDXZ2VYTANCNFSM6AAAAAA4SZUBYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Kristine M. Larson Professor Emerita, University of Bonn @.*** https://www.kristinelarson.net http://www.kristinelarson.net https://gnss-reflections.org https://github.com/kristinemlarson

Are you waiting for your code to be perfect?

-- Kristine M. Larson Professor Emerita, University of Bonn @.*** https://www.kristinelarson.net http://www.kristinelarson.net https://gnss-reflections.org https://github.com/kristinemlarson

Are you waiting for your code to be perfect?

naoyakadota commented 1 year ago

-lat 43.3849 -lon -80.2480 -ht 379.131

It has GPS/Galileo/Glonass/BeiDou signals (You may check the first 2 characters of headers - GP/GA/GL/BD represents each satellite system, respectively) with multiple frequencies (L1 & L2 - where you can distinguish from 'Signal ID' value on '-GSV' sentence.) all contained.

kristinemlarson commented 1 year ago

Thanks!

On Mon, Sep 11, 2023 at 2:31 PM Naoya Kadota @.***> wrote:

-lat 43.3849 -lon -80.2480 -ht 379.131

It has GPS/Galileo/Glonass/BeiDou signals (You may check the first 2 characters of headers - GP/GA/GL/BD represents each satellite system, respectively) with multiple frequencies (L1 & L2 - where you can distinguish from 'Signal ID' value on '-GSV' sentence.) all contained.

— Reply to this email directly, view it on GitHub https://github.com/kristinemlarson/gnssrefl/pull/188#issuecomment-1713785775, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSDAPDTXAVVGZZVSFSGJXTXZ4ADLANCNFSM6AAAAAA4SZUBYQ . You are receiving this because you commented.Message ID: @.***>

kristinemlarson commented 1 year ago

The previous version of nmea2snr only supported L1 signals - and for multi-GNSS, it wrote the output incorrectly (everything was L1). It also made very inefficient SNR files (i.e. one line per frequency per satellite, instead of putting all the SNR data on a single line as is normally done). so i have updated it to properly decipher multi-GNSS and handle L2 and L5 data if they exist. I am skeptical that it is handling the Beidou data correctly, as it puts the results in the L1 column (f=301). and gnssrefl does not really acknowledge such a frequency, as we call them 302 and 306. I also now allow it to access both precise GNSS and rapid GNSS multi-GNSS orbit files. It one fails, it tries to find the other. In both cases the orbits are from GFZ. You should not use NMEA az/el values - but if you insist, I believe it is still allowed if you set -risky T. To me the code seems a bit slow, but maybe that is because most of my test cases are 1-Hz.