search

kristinemlarson / gnssrefl

GNSS Interferometric Reflectometry Software (GNSS-IR)
GNU General Public License v3.0
151 stars 75 forks source link

Update Dockerfile #248

Closed timdittmann closed 6 months ago

timdittmann commented 6 months ago

addressing Issue 247: notes and context described in the issue.

timdittmann commented 6 months ago

This fails the smoke test for listing the pickle file now that we have deleted the copy command from the Dockerfile. We could remove this check or add some logic to check the repo path for the pickle file?

timdittmann commented 6 months ago

I commented out the pickle file check in the smoke test, but alternatively we could switch to: ls -l gnssrefl/gpt_1wA.pickle or copy the file into the $REFL_CODE in the smoke test run and then check if you wish to keep this test?

kristinemlarson commented 6 months ago

i'm not going to be able to respond to this until after the class. no point having a ls command that returns an error like that. we can simply retain the cp commands in Dockerfile and provide better documentation for why it is there.

kristinemlarson commented 6 months ago

I'll go ahead and change the documentation so that it explains why it is making those directories. Thanks much for looking into this.