search

kristinemlarson / gnssrefl

GNSS Interferometric Reflectometry Software (GNSS-IR)
GNU General Public License v3.0
151 stars 75 forks source link

Manu anais patch 1 #257

Closed ManuAnais closed 6 months ago

ManuAnais commented 6 months ago

Add new images

kristinemlarson commented 6 months ago

why did you change the relative links in first_drivethru.md to hard-coded ones? do the links fail in some way? i checked the pdf and the links seem to work there.

i am fine with taking out the table formatting.

k.

ManuAnais commented 6 months ago

I've double checked the existing first_drivethru.md and it seems all links are currently hard-coded as absolute paths to readthedocs:

https://raw.githubusercontent.com/kristinemlarson/gnssrefl/master/docs/pages/first_drivethru.md

Anyways, I'll submit a separate pull request without my changes to first_drivethu, then a link may be added manually later.

kristinemlarson commented 6 months ago

maybe i misread the PR. i had to do the full links because of the pdf version of the user guide. if i use relative links it doesn't seem to always work.

On Wed, Mar 13, 2024 at 10:24 PM ManuAnais @.***> wrote:

I've double checked the existing first_drivethru.md and it seems all links are currently hard-coded as absolute paths to readthedocs:

https://raw.githubusercontent.com/kristinemlarson/gnssrefl/master/docs/pages/first_drivethru.md

Anyways, I'll submit a separate pull request without my changes to first_drivethu, then a link may be added manually later.

— Reply to this email directly, view it on GitHub https://github.com/kristinemlarson/gnssrefl/pull/257#issuecomment-1995873728, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSDAPGRDCAU3A72BDSO3L3YYC7XZAVCNFSM6AAAAABEUMKPQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJVHA3TGNZSHA . You are receiving this because you commented.Message ID: @.***>

-- Kristine M. Larson Professor Emerita, University of Bonn @.*** https://www.kristinelarson.net http://www.kristinelarson.net https://gnss-reflections.org https://github.com/kristinemlarson

Are you waiting for your code to be perfect?

kristinemlarson commented 6 months ago

i'm confused. why are your uploads all gone now? i went to accept them and it was gone.

kristinemlarson commented 6 months ago

ok, you are going to resubmit.

kristinemlarson commented 6 months ago

let me go ahead and submit some of these figures for you. i don't want you to have waste time resubmitting htem. i'll let you know when they are there.

kristinemlarson commented 6 months ago

i have uploaded your nice page and linked it to first_drivethru. i made a few tiny edits, like i don't think you need to say 001 for day 1, it should only require 1. and -rhdot T is now the default. i hope i got all the figures. if i did not, please feel free to submit more PR. @ManuAnais @fgnievinski

fgnievinski commented 6 months ago

thank you for fixing it, @kristinemlarson! that was sort of a premature pull request, it had been based a very old fork version.