kristinemlarson / gnssrefl

GNSS Interferometric Reflectometry Software (GNSS-IR)
GNU General Public License v3.0
154 stars 76 forks source link

Resolving 'You have been misled' error? #270

Closed aaryan-rampal closed 6 months ago

aaryan-rampal commented 7 months ago

System (please complete the following information):

OS: [e.g. macOS, windows, etc...] Linux

Method you are running the code: Locally via pip install gnssrefl

Describe the bug I have a few local RINEX v2.11 files. I am trying to use rinex2snr to convert them into snr files and then run gnssir on them. When I run rinex2snr on them, I get this error: You have been misled. There are no S1/S2 data in this file.

Using a quick grep search, I can see that this error originates from gpssnr.f when npts == 0. In the code right above this error message, there is this for loop:

               s1 = obs(iobs(6),itrack)
               s2 = obs(iobs(7),itrack)
               ...
               ...
               ...
               if (s1.eq.0.d0 .and. s2.eq.0.d0) then
 c                 no data, SNR so do not print it
               else
                 call write_to_file(fileOUT, prn_pick, iprn,
      .           elev,azimuth, tod, s1,s2, s5)

                 npts = npts + 1
               endif

So, apparently, s1 and s2 are always zero in my RINEX file. I am not sure how gpssnr.f creates obs from the RINEX file. I am trying to debug this issue but have not gained progress because I am unfamiliar with fortran, and there seems to be no easy way to debug this because the fortran code is being used in the python program as a wrapper, and so I can't use a debugger for python or fortran exclusively.

The RINEX files are my own local copy. I am assuming this is an error on my end with the formatting of the files not being in a way rinex2snr expects. This is the relevant line in the RINEX files.

7    C1    P1    P2    L1    L2    S1    S2            # / TYPES OF OBSERV
kristinemlarson commented 7 months ago

your header has left a space for S1 and S2, but that doesn't mean the file has non-zero values. can you send me your rinex file offline? (hopefully not high-rate)

On Wed, Mar 27, 2024 at 12:35 PM Aaryan Rampal @.***> wrote:

System (please complete the following information):

OS: [e.g. macOS, windows, etc...] Linux

Method you are running the code: Locally via pip install gnssrefl

Describe the bug I have a few local RINEX v2.11 files. I am trying to use rinex2snr to convert them into snr files and then run gnssir on them. When I run rinex2snr on them, I get this error: You have been misled. There are no S1/S2 data in this file.

Using a quick grep search, I can see that this error originates from gpssnr.f when npts == 0. In the code right above this error message, there is this for loop:

           s1 = obs(iobs(6),itrack)
           s2 = obs(iobs(7),itrack)
           ...
           ...
           ...
           if (s1.eq.0.d0 .and. s2.eq.0.d0) then

c no data, SNR so do not print it else call write_to_file(fileOUT, prn_pick, iprn, . elev,azimuth, tod, s1,s2, s5)

             npts = npts + 1
           endif

So, apparently, s1 and s2 are always zero in my RINEX file. I am not sure how gpssnr.f creates obs from the RINEX file. I am trying to debug this issue but have not gained progress because I am unfamiliar with fortran, and there seems to be no easy way to debug this because the fortran code is being used in the python program as a wrapper, and so I can't use a debugger for python or fortran exclusively.

The RINEX files are my own local copy. I am assuming this is an error on my end with the formatting of the files not being in a way rinex2snr expects. This is the relevant line in the RINEX files.

7 C1 P1 P2 L1 L2 S1 S2 # / TYPES OF OBSERV

— Reply to this email directly, view it on GitHub https://github.com/kristinemlarson/gnssrefl/issues/270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSDAPBP436N7QSGZKU2JFTY2MGPPAVCNFSM6AAAAABFLNURM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTCNRQGQYDCOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Kristine M. Larson @.*** https://www.kristinelarson.net http://www.kristinelarson.net https://gnss-reflections.org https://github.com/kristinemlarson

Are you waiting for your code to be perfect?

kristinemlarson commented 7 months ago

If it was the case that all the SNR data were zeroes, maybe I should change the warning to "no non-zero SNR data?"