Closed MeanLowDrew closed 3 months ago
I’ll fix asap
Kristine M. Larson @.*** https://www.kristinelarson.net http://www.kristinelarson.net https://gnss-reflections.org https://github.com/kristinemlarson
Are you waiting for your code to be perfect?
On Tue, Jul 16, 2024 at 6:01 PM Drew Lindow @.***> wrote:
When deleting the rinex 3 file after conversion to rinex 2, the variable "r3_filename_new" does not get initialized if the rinex 3 file doesn't have a .crx file extension, causing a critical error with the rinex2snr conversion.
You can view, comment on, or merge this pull request online at:
https://github.com/kristinemlarson/gnssrefl/pull/297 Commit Summary
- d380843 https://github.com/kristinemlarson/gnssrefl/pull/297/commits/d3808435bb887bcba47708a538ac43fbc46f95a9 bugfix rinex 3 deletion
File Changes
(1 file https://github.com/kristinemlarson/gnssrefl/pull/297/files)
- M gnssrefl/gps.py https://github.com/kristinemlarson/gnssrefl/pull/297/files#diff-a96a15a0dce29fc9514c3fff9a9c355c03b86cabc7925f281b817749826afb3e (2)
Patch Links:
- https://github.com/kristinemlarson/gnssrefl/pull/297.patch
- https://github.com/kristinemlarson/gnssrefl/pull/297.diff
— Reply to this email directly, view it on GitHub https://github.com/kristinemlarson/gnssrefl/pull/297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSDAPBQUO6SC754EV3IIHLZMW65DAVCNFSM6AAAAABK7TKI42VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTEMZTGEZTMMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
I am embarrassed - I did not see this was a PR - I thought it was an issue - so I sat down and fixed it this morning without reading what you had posted. I very much appreciate your help on this - and please let me know if version 3.6.2 does not work.
No problem, version 3.6.2 is working great for me now.
When deleting the rinex 3 file after conversion to rinex 2, the variable "r3_filename_new" does not get initialized if the rinex 3 file doesn't have a .crx file extension, causing a critical error with the rinex2snr conversion.