search

kristiyanP / colorpicker

A simple color picker library for Android
Apache License 2.0
193 stars 43 forks source link

Removal of OnFastChooseListener #20

Open KlutzyBubbles opened 6 years ago

KlutzyBubbles commented 6 years ago

Don't see the point in it, i created a fork located https://github.com/KlutzyBubbles/colorpicker/tree/master/colorpicker-library/src/main/java/petrov/kristiyan/colorpicker which contains the changes to remove the interface.

Reasoning: i was developing with the library and found that

  1. the method within the interface was incorrectly named (setOnFastChangeListener instead of onFastChange)
  2. It was extremely frustrating when creating similar code to have to rename the method and the interface for the exact same code (for setting color variables)

An option IF you really dont want to remove the OnFastChangeListener is to make it the same method names as both interfaces were made to provide the same data for the same output just via a different path.

Wanted to create an issue for this before i make a pull request.

kristiyanP commented 6 years ago

I would gladly accept a pull request with a refactor for the method name as i think the method is fairly necessary.

mustafamn commented 6 years ago

i m getting an extra 2 row while i did not apply the color..???