Fix various issues with the current implementation

kristjanmik / kjosturett-web

One stop for Parliament elections in Iceland - http://kjosturett.is

http://kjosturett.is

Other

24 stars 16 forks source link

Fix various issues with the current implementation #73

Closed hauxir closed 1 week ago

hauxir commented 1 month ago

Take into account answers that are 0 in results -- major issue, Mjög óssammála ignored in results
Prevent null! being stored as a string when marking a question as important by setting it as 2 by default
Fix off by one error where 3 was assumed to be neutral when in reality it is 2

axelg12 commented 1 month ago

Looks good! Only thing I am wondering is that we are going to modify the scale so instead of 5 point scale we go to a 4 point scale and include "skip", basically making it a 5 point scale. So this might need to reflect that changes as well?

That change is being implemented here https://github.com/kristjanmik/kjosturett-web/pull/74

axelg12 commented 3 weeks ago

This should now be fixed with the latest release

axelg12 commented 1 week ago

Closing as this has already been implemented with the new SVT solution