search

kristjanvalur / py-asynkit

Tools for Python coroutines and advanced scheduling for `asyncio`
MIT License
13 stars 1 forks source link

Add py typed #2

Closed laky55555 closed 1 year ago

kristjanvalur commented 1 year ago

Hi, thanks for your contribution, you got first post!. py.typed is empty is this intentional? I'm not super familiar with this pep https://peps.python.org/pep-0561/ can you explain what we gain by this? is having this better than inline type hints? (I also need to read the pep to understand what's going on)

laky55555 commented 1 year ago

I also don't have that good knowledge about PEP-561, but in nutshell, for the package to be compliant with it (expose types) it needs to have py.typed https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages. So empty file would just leave types to be deduced in best effort manner by the checker. image

kristjanvalur commented 1 year ago

Thanks!