If the nodes list was resized, then the pointer to the root could no longer be valid, and the stored pointer was being compared when finalizing the tree. This meant that if the root node was no longer at that address, it would attempt to call isClosed() on the root which hits unreachable.
Ast: Fix test cases
Fixes compile errors, skips tests that panic during render due to error.len != 0, and update one test to match the current behavior
Note: This does not get zig build test working, since it runs the tests in SuperTree.zig which fail to compile (and if that's fixed, then the tests fail, too). I just left that alone because I don't really understand if/how it fits into the current state of the project.
Ast: Fix usage of dangling pointer to root node
If the nodes list was resized, then the pointer to the root could no longer be valid, and the stored pointer was being compared when finalizing the tree. This meant that if the root node was no longer at that address, it would attempt to call
isClosed()
on the root which hits unreachable.Ast: Fix test cases
Fixes compile errors, skips tests that panic during render due to error.len != 0, and update one test to match the current behavior
Tokenizer: Skip failing test case (related: https://github.com/kristoff-it/super-html/issues/6)
Note: This does not get
zig build test
working, since it runs the tests inSuperTree.zig
which fail to compile (and if that's fixed, then the tests fail, too). I just left that alone because I don't really understand if/how it fits into the current state of the project.