search

kristoff-it / superhtml

HTML Language Server & Templating Language Library
MIT License
172 stars 11 forks source link

Add version subcommand #18

Closed luka-hash closed 1 month ago

luka-hash commented 1 month ago

I guess this is mostly self-explanatory (i.e. version string was already present, I've just added another subcommand and a switch case to check for it). Other 'changes' are just a result of zed removing trailing whitespace on save; hope this is not a problem.

Also, why is help message treated as a fatal error (i.e. it returns 1 instead of 0)? It is a valid command after all.

luka-hash commented 1 month ago

Also, I haven't checked before opening PR, but the version string should probably be updated. In cli.zig it is 0.1.4, in .zon file it is 0.0.0, and the latest release is tagged as 0.3.1.

kristoff-it commented 1 month ago

thank you, the help menu is an error mainly because we print it every time an argument parsing error is found. I don't have strong opinions on the matter but I believe other tools do that as well (perhaps for the same reason)