search

kristoff-it / superhtml

HTML Language Server & Templating Language Library
MIT License
172 stars 11 forks source link

Fix missing version field #22

Closed EliSauder closed 1 month ago

EliSauder commented 1 month ago

After resolving llvm-conf dependency, there is still a build issue where cli.zig is missing a version field. Added it in using the build_options already available.

EliSauder commented 1 month ago

Image of working build:

image
EliSauder commented 1 month ago

See #21 for some details :)

kristoff-it commented 1 month ago

I've fixed the overly aggressive dependency on llvm-config inherited by allyourcodebase/AFLplusplus, but I'm not sure why adding a version variable is needed. Current HEAD builds for me and printVersion does use build_opitons.version, am I missing something?

EliSauder commented 1 month ago

I sent this in #21 but not here (dumb moment). This is a build error I got after resolving the llvm-config dependency image

kristoff-it commented 1 month ago

can you try pulling from master and building? It should all be fixed now

EliSauder commented 1 month ago

I'll need to try that in a few hours when I have access to my computer again. I'll see if I can test it sooner, but I'm getting some TlsInitializationFailed errors with zon on my current network

kristoff-it commented 1 month ago

I see, in any case I think it's safe to say that everything should be working fine now, CI is now also back to green :^)

EliSauder commented 1 month ago

I see, in any case I think it's safe to say that everything should be working fine now, CI is now also back to green :^)

Yup, this appears to be working on my device as well