search

kristopolous / BOOTSTRA.386

A vintage 1980s DOS inspired Twitter Bootstrap theme
https://bootstra386.com
Apache License 2.0
6.63k stars 309 forks source link

Shadows and a correction #132

Open jmfergeau opened 1 year ago

jmfergeau commented 1 year ago

This adds the shadow class for bootstra 4.4.1. This adds the shadow effect to basically any element you want, like in the original bootstrap. Also works with shadow-sm and shadow-lg with the same effect as fallback for bootstrap.

The shadow class used on cards elements These are card elements with the shadow class added.

Note that it only works right with blocks that have a filled color like cards, alert boxes, jombotron, etc.

This also corrects a missing ; that prevents scss compilation.

kristopolous commented 1 year ago

thanks ... my notifications are basically endless floods of noise on github so sorry if I don't respond sooner. I'll review the code and get back to you.

kristopolous commented 1 year ago

Alright reviewed, I'm going to ask you to replace your constants with the variable system that is used in the codebase. Please refer to the variables scss flie for reference.

Other than that, it's fine with one potential nice hack. The master class way of pulling this off would be through css filters and not merely a shadow css directive.

I forget whether I attempted this or not 3 years ago but in practice, some shadow implementations wouldn't occlude the background text but instead change the color scheme.

This is ONLY doable if you choose to have full-height bottom shadow. Right now you've gone with half-height. If that is the intention then there's still something that needs to be done.

You're simulating MS-ASCII 220 here. In this case you'll need to block out the bottom pixels because you're "replacing" it. msdos_festival_ASCII

There's various ways of doing this that require a bizarre level of wizardry. I believe the source has some.

You can punt on all of these and just add the variables and I'll do them.