search

kristovatlas / osx-config-check

Verify the configuration of your OS X machine.
MIT License
1.25k stars 111 forks source link

config 40 fix: user confusingly prompted for license agreement with popup #162

Open kristovatlas opened 8 years ago

kristovatlas commented 8 years ago

If the user hasn't agreed to the license terms for Command Line Tools, this will pop up for config check 40.

A simple way to alleviate this would be to check whether the license has been accepted early on in the checks and encourage the user to accept before moving on. (This may require some additional app functionality to encourage the user to do this in another window: "Press enter for the next check. If you are prompted with a license agreement, accept it before moving on...")

It might also make sense to modify the fix so that it is only attempted if the license check passes earlier on, perhaps by setting a temporary file during that check, or via a new app feature that stores the outcome of checks and can be referenced by future checks.

kristovatlas commented 8 years ago

CHECK #40: git is up to date or is not installed test: git --version fix: brew update ; brew install git ; brew upgrade git ; python ./scripts/set_path_precedence.py "/usr/local/bin" "/usr/bin"