kriswallsmith / Buzz

PHP's lightweight HTTP client
MIT License
1.92k stars 250 forks source link

Update composer and tests to support php 8 #417

Closed sunkan closed 4 years ago

sunkan commented 4 years ago

This is the smallest change I could make and make the tests pass and work on both php 7.1 and php 8.0.0-rc1

I haven't update the ci.yml due to not being familiar with that setup

chris-doehring commented 4 years ago

Hi @sunkan,

I was also trying to make Buzz php 8 compatible a few days ago but ran into an incompatibility regarding the multi curl server push functionality. There must be some bug or change in the curl version that php 8 is using, that makes the multi curl server push support of this package incompatible. I deactivated it for php 8 as it is only activated for php 7.4 anyway.

You can check out the progress I did so far: https://github.com/kriswallsmith/Buzz/compare/master...chris-doehring:feature/php8

Maybe the best thing would be to combine efforts here? I think I will create a pull request in your fork to add the remaining changes I did including the ci.yml changes, so it will be in this pull request after merging.

sunkan commented 4 years ago

@Nyholm

This now passes all checks thanks to @chris-doehring

Could we get this merged?