Usage of $http_response_header without checking

kriswallsmith / assetic

Asset Management for PHP

MIT License

3.75k stars 555 forks source link

Usage of $http_response_header without checking #346

Open woodworker opened 11 years ago

woodworker commented 11 years ago

The $http_response_header variable will be just used without checking. but if there is php with curlwrappers enabled this variable is not set

Sample: https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Asset/HttpAsset.php#L73

kriswallsmith commented 11 years ago

How do you get the response headers when curlwrappers are enabled?

woodworker commented 11 years ago

i will test it (i recompiled my php at the moment without curlwrappers) but the first thing what comes to my mind is the stream context and stream_get_meta_data

http://php.net/manual/en/context.http.php

ghost commented 11 years ago

curlwrappers are removed altogether in php 5.5

https://wiki.php.net/rfc/curl-wrappers-removal-rfc