search

kriswallsmith / assetic

Asset Management for PHP
MIT License
3.75k stars 555 forks source link

leafo/lessphp not actively developed anymore. Replace with oyejorge/less.php ? #557

Open mweimerskirch opened 10 years ago

mweimerskirch commented 10 years ago

Lessphp seems not to be actively developed anymore: https://github.com/leafo/lessphp/issues/503#issuecomment-31332372 This is annoying because current versions of Bootstrap are not supported any more.

I'd like to suggest replacing it with https://github.com/oyejorge/less.php/

I can write a patch, but I'd first like to know what others think about this.

kingcrunch commented 10 years ago

Wouldn't it be better fix leafo/lessphp instead?

Does anyone want commit access to this repo? The stuff that is missing for BS3 is actually fairly minimal. Biggest show stopper for latest less version is extends, if it's the same as SCSS then I've already implemented it for https://github.com/leafo/scssphp

mistergraphx commented 10 years ago

Hi, is it possible to set variables from php with this new library ?

Because actualy i use this with leafo/lessphp

stof commented 10 years ago

@mistergraphx AFAICT, it does not.

However, nothing would forbid us to support both libraries in Assetic (we just need to find a name for the filter based on less.php)

kingcrunch commented 10 years ago

@stof I already know, that it is very confusing, but following the schema it should be less.php :smile:

stof commented 10 years ago

We cannot use dots in a class name, and I don't think it is allowed either in filter names

mweimerskirch commented 10 years ago

@KingCrunch The issues with Bootstrap 3 are just why I noticed that it is no longer supported. Other incompatibilites might arise. @mistergraphx Not as far as I know. @stof I agree, that might be the better solution. I'm willing to create a pull request for this. Altough finding a name for the class might a bit of a problem ;-)

The setting in the AsseticBundle could be called "less.php" - although that might lead to some confusion - so "oyejorgelessphp" might be a better choice. The filter class for the old LessPHP is simply called "LessphpFilter". The new one could be called "OyejorgeLessphpFilter"?

grizzm0 commented 10 years ago

I was working on a filter to work with less.php myself when I noticed that less.php ships with lessc.inc.php. Using ZF2 + AssetManager (which depends on assetic) myself. I got bootstrap 3.1.* to compile by just replacing leafo/lessphp with oyejorge/less.php in my composer.json.

A separate filter wouldn't hurt... But the current one works due to less.php's "compat layer".

dustingraham commented 10 years ago

Replacing the dependency worked for me with Laravel 4 + Assetic as well. Thanks @grizzm0

cyberlussi commented 10 years ago

+1 for replacing leafo/lessphp