search

kriswallsmith / assetic

Asset Management for PHP
MIT License
3.75k stars 555 forks source link

Provide support for Symfony 4. #878

Closed joebenson closed 6 years ago

joebenson commented 6 years ago

I've made changes to support Symfony 4 (and therefore Laravel 5.6) by following the Symfony upgrade guide here.

joebenson commented 6 years ago

Note: This pull request requires PHP >= 7.1.3 (Symfony dependency).

joebenson commented 6 years ago

Sorry, just read the comment in another issue that you're not looking to manage a 2.x branch of this in order to facilitate supporting Symfony 4. After looking into it further, there are some additional changes that need to be made in order to work with the breaking changes Symfony 4 introduces. If you'd be interested in merging the changes, let me know and I can push up the additional commits. Otherwise I'll leave the commits out and close this pull request for now.