search

kriswiner / CMWX1ZZABZ

Collection of sketches using the Arduino core for Murata's CMWX1ZZABZ (STM32L082 and SX1276)
94 stars 30 forks source link

GasCap adjusting indentation #35

Closed DanielArnett closed 1 year ago

DanielArnett commented 1 year ago

There were some areas where the indentation wasn't quite right so VSCode's automatic indentation was used to automate some of the formatting. I rolled back some of the changes where it made sense (keeping some print statements all in one line), but now for the GasCap folder the indentation should be 100% correct.

It wouldn't build because some of the include statements referenced I2CDev.h (upper-case d) and the file was named I2Cdev.h (lower-case d), now those match.

There were some instances of I2Cdev.h being referenced by both a cpp file and its header. Now it's just being referenced in the header.

Since this PR is almost entirely whitespace changes my only validation test was to build. I use the arduino command-line tool, so the build command was

cd GasCap/AssetTracker_GasCap_v.02e/
arduino-cli compile --export-binaries --fqbn TleraCorp:stm32l0:Cricket-L082CZ

Which compiled as expected.

kriswiner commented 1 year ago

Thanks Daniel!

kriswiner commented 1 year ago

Hi Daniel,

Just wanted to make you aware that the public Arduino core has a "bug" where the GNSS serial instantiation isn't at the lowest power consumption when the GasCap (or Gnat) is asleep as it should. The extra current consumption amounts to about 15 uA. There is a private core (on GitHub) where this is fixed such that the GasCap (or Gnat) sleep current is reduced from ~32 uA to ~17 uA with the GNSS backup on and from ~17 uA to ~2 uA with the GNSS backup off. This doesn't affect every use case but in the case yours requires the lowest sleep current I would recommend that you use the "private" Arduino core for your GasCaps.

Please let me know if this isn't clear or you need further information, etc.

Kris

On Mon, Apr 10, 2023 at 4:44 PM Daniel Arnett @.***> wrote:

There were some areas where the indentation wasn't quite right so VSCode's automatic indentation was used to automate some of the formatting. I rolled back some of the changes where it made sense (keeping some print statements all in one line), but now for the GasCap folder the indentation should be 100% correct.

It wouldn't build because some of the include statements referenced I2CDev.h (upper-case d) and the file was named I2Cdev.h (lower-case d), now those match.

There were some instances of I2Cdev.h being referenced by both a cpp file and its header. Now it's just being referenced in the header.

Since this PR is almost entirely whitespace changes my only validation test was to build. I use the arduino command-line tool, so the build command was

cd GasCap/AssetTracker_GasCap_v.02e/ arduino-cli compile --export-binaries --fqbn TleraCorp:stm32l0:Cricket-L082CZ

Which compiled as expected.

You can view, comment on, or merge this pull request online at:

https://github.com/kriswiner/CMWX1ZZABZ/pull/35 Commit Summary

File Changes

(12 files https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTDLKXUSCP7EPUGXKP6EF3XASLOFANCNFSM6AAAAAAWZROGNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

DanielArnett commented 1 year ago

Thanks for the heads up. Is the fixed version Thomas's core or a fork of it?

On Tue, May 23, 2023, 21:11 Kris Winer @.***> wrote:

Hi Daniel,

Just wanted to make you aware that the public Arduino core has a "bug" where the GNSS serial instantiation isn't at the lowest power consumption when the GasCap (or Gnat) is asleep as it should. The extra current consumption amounts to about 15 uA. There is a private core (on GitHub) where this is fixed such that the GasCap (or Gnat) sleep current is reduced from ~32 uA to ~17 uA with the GNSS backup on and from ~17 uA to ~2 uA with the GNSS backup off. This doesn't affect every use case but in the case yours requires the lowest sleep current I would recommend that you use the "private" Arduino core for your GasCaps.

Please let me know if this isn't clear or you need further information, etc.

Kris

On Mon, Apr 10, 2023 at 4:44 PM Daniel Arnett @.***> wrote:

There were some areas where the indentation wasn't quite right so VSCode's automatic indentation was used to automate some of the formatting. I rolled back some of the changes where it made sense (keeping some print statements all in one line), but now for the GasCap folder the indentation should be 100% correct.

It wouldn't build because some of the include statements referenced I2CDev.h (upper-case d) and the file was named I2Cdev.h (lower-case d), now those match.

There were some instances of I2Cdev.h being referenced by both a cpp file and its header. Now it's just being referenced in the header.

Since this PR is almost entirely whitespace changes my only validation test was to build. I use the arduino command-line tool, so the build command was

cd GasCap/AssetTracker_GasCap_v.02e/ arduino-cli compile --export-binaries --fqbn TleraCorp:stm32l0:Cricket-L082CZ

Which compiled as expected.

You can view, comment on, or merge this pull request online at:

https://github.com/kriswiner/CMWX1ZZABZ/pull/35 Commit Summary

Whitespace changes to make GasCap more readable.

Finish fixing whitespace issues. All files in GasCap folder should now have the proper indentation. The only logic changes were two times where a redundant Serial.print();Serial.println() was simplified to Serial.println(). Removed imports of I2Cdev.h that were duplicated in both header files and cpp files.

File Changes

(12 files https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files)

(1029)

(203)

(102)

(160)

(26)

(351)

(2)

(77)

(45)

(81)

(43)

  • M

GasCap/readSPIFlash_GasCapAssetTracker/readSPIFlash_GasCapAssetTracker.ino < https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-bd0750ed44f6d8c5c076cc3ac93e844ee952b734f1ecc5d3b5e511b48d294ca9

(255)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABTDLKXUSCP7EPUGXKP6EF3XASLOFANCNFSM6AAAAAAWZROGNY

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560321529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXDT7TUMFER5SXH5BKWIMTXHVN5BANCNFSM6AAAAAAWZROGNY . You are receiving this because you authored the thread.Message ID: @.***>

kriswiner commented 1 year ago

It is a private version reposited here https://github.com/kriswiner/CMWX1ZZABZ/tree/master/privateCore.

A few changes to some calls, we are working to make this public....

Please let me know when you have questions.

On Tue, May 23, 2023 at 6:22 PM Daniel Arnett @.***> wrote:

Thanks for the heads up. Is the fixed version Thomas's core or a fork of it?

On Tue, May 23, 2023, 21:11 Kris Winer @.***> wrote:

Hi Daniel,

Just wanted to make you aware that the public Arduino core has a "bug" where the GNSS serial instantiation isn't at the lowest power consumption when the GasCap (or Gnat) is asleep as it should. The extra current consumption amounts to about 15 uA. There is a private core (on GitHub) where this is fixed such that the GasCap (or Gnat) sleep current is reduced from ~32 uA to ~17 uA with the GNSS backup on and from ~17 uA to ~2 uA with the GNSS backup off. This doesn't affect every use case but in the case yours requires the lowest sleep current I would recommend that you use the "private" Arduino core for your GasCaps.

Please let me know if this isn't clear or you need further information, etc.

Kris

On Mon, Apr 10, 2023 at 4:44 PM Daniel Arnett @.***> wrote:

There were some areas where the indentation wasn't quite right so VSCode's automatic indentation was used to automate some of the formatting. I rolled back some of the changes where it made sense (keeping some print statements all in one line), but now for the GasCap folder the indentation should be 100% correct.

It wouldn't build because some of the include statements referenced I2CDev.h (upper-case d) and the file was named I2Cdev.h (lower-case d), now those match.

There were some instances of I2Cdev.h being referenced by both a cpp file and its header. Now it's just being referenced in the header.

Since this PR is almost entirely whitespace changes my only validation test was to build. I use the arduino command-line tool, so the build command was

cd GasCap/AssetTracker_GasCap_v.02e/ arduino-cli compile --export-binaries --fqbn TleraCorp:stm32l0:Cricket-L082CZ

Which compiled as expected.

You can view, comment on, or merge this pull request online at:

https://github.com/kriswiner/CMWX1ZZABZ/pull/35 Commit Summary

  • b2f65bc <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/commits/b2f65bce58a78d75ab874dc5d8bf9875b4c6e6d0

Whitespace changes to make GasCap more readable.

  • 6605cbf <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/commits/6605cbf3e78371e5e52d33d47da49fdd293e79ba

Finish fixing whitespace issues. All files in GasCap folder should now have the proper indentation. The only logic changes were two times where a redundant Serial.print();Serial.println() was simplified to Serial.println(). Removed imports of I2Cdev.h that were duplicated in both header files and cpp files.

File Changes

(12 files https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files)

  • M GasCap/AssetTracker_GasCap_v.02e/AssetTracker_GasCap_v.02e.ino <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-5768d75659e3f99769d705e334401d814d5f84438de0da972f331e68928a9a56

(1029)

  • M GasCap/AssetTracker_GasCap_v.02e/BME280.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-c0ccd1f91fa4ee3d4eac54b188d5becb5c15a06cc4fc4517a126ca06e666364c

(203)

  • M GasCap/AssetTracker_GasCap_v.02e/BME280.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-5dd6eeaff757d1739a86518bd93832f66f2a84ad68dd208f1db5bdc397e2472e

(102)

  • M GasCap/AssetTracker_GasCap_v.02e/I2Cdev.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-b2e849be3ead54940df06d103ec23b3c0803f314a0af3cc42bd96e9766cc3ec0

(160)

  • M GasCap/AssetTracker_GasCap_v.02e/I2Cdev.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-4786cc73c5c54594782eea693a202c2f10a88bcd3283bacf9c9124e6751dbee4

(26)

  • M GasCap/AssetTracker_GasCap_v.02e/LIS2DW12.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-802f22b659ba365665b59c7823a4c9d92e014a5e09fd15eb3addc0fe1d6aa78c

(351)

  • M GasCap/AssetTracker_GasCap_v.02e/LIS2DW12.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-97c5224dfa0e0825da65d764d7dbf6e934cee9c509144318b960cf28d1518598

(2)

  • M GasCap/AssetTracker_GasCap_v.02e/SPIFlash.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-6e1d2154c9c9c620304cb1018c6f134b68f171e3f5a32075699a337253cd42ac

(77)

  • M GasCap/AssetTracker_GasCap_v.02e/SPIFlash.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-fac3dcff0930a29ec9207386ccdf4022e0d945c83d17bda9a6d4abad02e6d010

(45)

  • M GasCap/readSPIFlash_GasCapAssetTracker/SPIFlash.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-fca24acfeb8f0480ea690c28113da49bc36519a28084dd7c4fef09ef60be3c1d

(81)

  • M GasCap/readSPIFlash_GasCapAssetTracker/SPIFlash.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-b66d23288e1a738a19d15ac88da45610731149bb42c3f1739a9114e68783fe18

(43)

  • M

GasCap/readSPIFlash_GasCapAssetTracker/readSPIFlash_GasCapAssetTracker.ino

<

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-bd0750ed44f6d8c5c076cc3ac93e844ee952b734f1ecc5d3b5e511b48d294ca9

(255)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABTDLKXUSCP7EPUGXKP6EF3XASLOFANCNFSM6AAAAAAWZROGNY

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub <https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560321529 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAXDT7TUMFER5SXH5BKWIMTXHVN5BANCNFSM6AAAAAAWZROGNY

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560330211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTDLKQLCBKZFSJHQXS7AP3XHVPG3ANCNFSM6AAAAAAWZROGNY . You are receiving this because you modified the open/close state.Message ID: @.***>

DanielArnett commented 1 year ago

Thanks, I'll test it out. I've been meaning to test and double check my state machine is actually setting the power consumption the way that I've been assuming.

Btw I've been meaning to ask: we don't receive bytes when the stm32 is in stop mode, correct? In my tests a while ago it looked like only a handful of bytes were received in stop mode, and not my entire packets.

On Tue, May 23, 2023, 21:29 Kris Winer @.***> wrote:

It is a private version reposited here https://github.com/kriswiner/CMWX1ZZABZ/tree/master/privateCore.

A few changes to some calls, we are working to make this public....

Please let me know when you have questions.

On Tue, May 23, 2023 at 6:22 PM Daniel Arnett @.***> wrote:

Thanks for the heads up. Is the fixed version Thomas's core or a fork of it?

On Tue, May 23, 2023, 21:11 Kris Winer @.***> wrote:

Hi Daniel,

Just wanted to make you aware that the public Arduino core has a "bug" where the GNSS serial instantiation isn't at the lowest power consumption when the GasCap (or Gnat) is asleep as it should. The extra current consumption amounts to about 15 uA. There is a private core (on GitHub) where this is fixed such that the GasCap (or Gnat) sleep current is reduced from ~32 uA to ~17 uA with the GNSS backup on and from ~17 uA to ~2 uA with the GNSS backup off. This doesn't affect every use case but in the case yours requires the lowest sleep current I would recommend that you use the "private" Arduino core for your GasCaps.

Please let me know if this isn't clear or you need further information, etc.

Kris

On Mon, Apr 10, 2023 at 4:44 PM Daniel Arnett @.***> wrote:

There were some areas where the indentation wasn't quite right so VSCode's automatic indentation was used to automate some of the formatting. I rolled back some of the changes where it made sense (keeping some print statements all in one line), but now for the GasCap folder the indentation should be 100% correct.

It wouldn't build because some of the include statements referenced I2CDev.h (upper-case d) and the file was named I2Cdev.h (lower-case d), now those match.

There were some instances of I2Cdev.h being referenced by both a cpp file and its header. Now it's just being referenced in the header.

Since this PR is almost entirely whitespace changes my only validation test was to build. I use the arduino command-line tool, so the build command was

cd GasCap/AssetTracker_GasCap_v.02e/ arduino-cli compile --export-binaries --fqbn TleraCorp:stm32l0:Cricket-L082CZ

Which compiled as expected.

You can view, comment on, or merge this pull request online at:

https://github.com/kriswiner/CMWX1ZZABZ/pull/35 Commit Summary

  • b2f65bc <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/commits/b2f65bce58a78d75ab874dc5d8bf9875b4c6e6d0

Whitespace changes to make GasCap more readable.

  • 6605cbf <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/commits/6605cbf3e78371e5e52d33d47da49fdd293e79ba

Finish fixing whitespace issues. All files in GasCap folder should now have the proper indentation. The only logic changes were two times where a redundant Serial.print();Serial.println() was simplified to Serial.println(). Removed imports of I2Cdev.h that were duplicated in both header files and cpp files.

File Changes

(12 files https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files)

  • M GasCap/AssetTracker_GasCap_v.02e/AssetTracker_GasCap_v.02e.ino <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-5768d75659e3f99769d705e334401d814d5f84438de0da972f331e68928a9a56

(1029)

  • M GasCap/AssetTracker_GasCap_v.02e/BME280.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-c0ccd1f91fa4ee3d4eac54b188d5becb5c15a06cc4fc4517a126ca06e666364c

(203)

  • M GasCap/AssetTracker_GasCap_v.02e/BME280.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-5dd6eeaff757d1739a86518bd93832f66f2a84ad68dd208f1db5bdc397e2472e

(102)

  • M GasCap/AssetTracker_GasCap_v.02e/I2Cdev.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-b2e849be3ead54940df06d103ec23b3c0803f314a0af3cc42bd96e9766cc3ec0

(160)

  • M GasCap/AssetTracker_GasCap_v.02e/I2Cdev.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-4786cc73c5c54594782eea693a202c2f10a88bcd3283bacf9c9124e6751dbee4

(26)

  • M GasCap/AssetTracker_GasCap_v.02e/LIS2DW12.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-802f22b659ba365665b59c7823a4c9d92e014a5e09fd15eb3addc0fe1d6aa78c

(351)

  • M GasCap/AssetTracker_GasCap_v.02e/LIS2DW12.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-97c5224dfa0e0825da65d764d7dbf6e934cee9c509144318b960cf28d1518598

(2)

  • M GasCap/AssetTracker_GasCap_v.02e/SPIFlash.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-6e1d2154c9c9c620304cb1018c6f134b68f171e3f5a32075699a337253cd42ac

(77)

  • M GasCap/AssetTracker_GasCap_v.02e/SPIFlash.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-fac3dcff0930a29ec9207386ccdf4022e0d945c83d17bda9a6d4abad02e6d010

(45)

  • M GasCap/readSPIFlash_GasCapAssetTracker/SPIFlash.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-fca24acfeb8f0480ea690c28113da49bc36519a28084dd7c4fef09ef60be3c1d

(81)

  • M GasCap/readSPIFlash_GasCapAssetTracker/SPIFlash.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-b66d23288e1a738a19d15ac88da45610731149bb42c3f1739a9114e68783fe18

(43)

  • M

GasCap/readSPIFlash_GasCapAssetTracker/readSPIFlash_GasCapAssetTracker.ino

<

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-bd0750ed44f6d8c5c076cc3ac93e844ee952b734f1ecc5d3b5e511b48d294ca9

(255)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABTDLKXUSCP7EPUGXKP6EF3XASLOFANCNFSM6AAAAAAWZROGNY

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560321529 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAXDT7TUMFER5SXH5BKWIMTXHVN5BANCNFSM6AAAAAAWZROGNY

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub <https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560330211 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABTDLKQLCBKZFSJHQXS7AP3XHVPG3ANCNFSM6AAAAAAWZROGNY

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560334087, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXDT7QKEOKL7OOSQBY3KIDXHVP5ZANCNFSM6AAAAAAWZROGNY . You are receiving this because you authored the thread.Message ID: @.***>

kriswiner commented 1 year ago

Correct, when the MCU is in STOP mode the LoRaWAN radio is off.

On Tue, May 23, 2023 at 6:51 PM Daniel Arnett @.***> wrote:

Thanks, I'll test it out. I've been meaning to test and double check my state machine is actually setting the power consumption the way that I've been assuming.

Btw I've been meaning to ask: we don't receive bytes when the stm32 is in stop mode, correct? In my tests a while ago it looked like only a handful of bytes were received in stop mode, and not my entire packets.

On Tue, May 23, 2023, 21:29 Kris Winer @.***> wrote:

It is a private version reposited here https://github.com/kriswiner/CMWX1ZZABZ/tree/master/privateCore.

A few changes to some calls, we are working to make this public....

Please let me know when you have questions.

On Tue, May 23, 2023 at 6:22 PM Daniel Arnett @.***> wrote:

Thanks for the heads up. Is the fixed version Thomas's core or a fork of it?

On Tue, May 23, 2023, 21:11 Kris Winer @.***> wrote:

Hi Daniel,

Just wanted to make you aware that the public Arduino core has a "bug" where the GNSS serial instantiation isn't at the lowest power consumption when the GasCap (or Gnat) is asleep as it should. The extra current consumption amounts to about 15 uA. There is a private core (on GitHub) where this is fixed such that the GasCap (or Gnat) sleep current is reduced from ~32 uA to ~17 uA with the GNSS backup on and from ~17 uA to ~2 uA with the GNSS backup off. This doesn't affect every use case but in the case yours requires the lowest sleep current I would recommend that you use the "private" Arduino core for your GasCaps.

Please let me know if this isn't clear or you need further information, etc.

Kris

On Mon, Apr 10, 2023 at 4:44 PM Daniel Arnett @.***> wrote:

There were some areas where the indentation wasn't quite right so VSCode's automatic indentation was used to automate some of the formatting. I rolled back some of the changes where it made sense (keeping some print statements all in one line), but now for the GasCap folder the indentation should be 100% correct.

It wouldn't build because some of the include statements referenced I2CDev.h (upper-case d) and the file was named I2Cdev.h (lower-case d), now those match.

There were some instances of I2Cdev.h being referenced by both a cpp file and its header. Now it's just being referenced in the header.

Since this PR is almost entirely whitespace changes my only validation test was to build. I use the arduino command-line tool, so the build command was

cd GasCap/AssetTracker_GasCap_v.02e/ arduino-cli compile --export-binaries --fqbn TleraCorp:stm32l0:Cricket-L082CZ

Which compiled as expected.

You can view, comment on, or merge this pull request online at:

https://github.com/kriswiner/CMWX1ZZABZ/pull/35 Commit Summary

  • b2f65bc <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/commits/b2f65bce58a78d75ab874dc5d8bf9875b4c6e6d0

Whitespace changes to make GasCap more readable.

  • 6605cbf <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/commits/6605cbf3e78371e5e52d33d47da49fdd293e79ba

Finish fixing whitespace issues. All files in GasCap folder should now have the proper indentation. The only logic changes were two times where a redundant Serial.print();Serial.println() was simplified to Serial.println(). Removed imports of I2Cdev.h that were duplicated in both header files and cpp files.

File Changes

(12 files https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files)

  • M GasCap/AssetTracker_GasCap_v.02e/AssetTracker_GasCap_v.02e.ino <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-5768d75659e3f99769d705e334401d814d5f84438de0da972f331e68928a9a56

(1029)

  • M GasCap/AssetTracker_GasCap_v.02e/BME280.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-c0ccd1f91fa4ee3d4eac54b188d5becb5c15a06cc4fc4517a126ca06e666364c

(203)

  • M GasCap/AssetTracker_GasCap_v.02e/BME280.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-5dd6eeaff757d1739a86518bd93832f66f2a84ad68dd208f1db5bdc397e2472e

(102)

  • M GasCap/AssetTracker_GasCap_v.02e/I2Cdev.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-b2e849be3ead54940df06d103ec23b3c0803f314a0af3cc42bd96e9766cc3ec0

(160)

  • M GasCap/AssetTracker_GasCap_v.02e/I2Cdev.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-4786cc73c5c54594782eea693a202c2f10a88bcd3283bacf9c9124e6751dbee4

(26)

  • M GasCap/AssetTracker_GasCap_v.02e/LIS2DW12.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-802f22b659ba365665b59c7823a4c9d92e014a5e09fd15eb3addc0fe1d6aa78c

(351)

  • M GasCap/AssetTracker_GasCap_v.02e/LIS2DW12.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-97c5224dfa0e0825da65d764d7dbf6e934cee9c509144318b960cf28d1518598

(2)

  • M GasCap/AssetTracker_GasCap_v.02e/SPIFlash.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-6e1d2154c9c9c620304cb1018c6f134b68f171e3f5a32075699a337253cd42ac

(77)

  • M GasCap/AssetTracker_GasCap_v.02e/SPIFlash.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-fac3dcff0930a29ec9207386ccdf4022e0d945c83d17bda9a6d4abad02e6d010

(45)

  • M GasCap/readSPIFlash_GasCapAssetTracker/SPIFlash.cpp <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-fca24acfeb8f0480ea690c28113da49bc36519a28084dd7c4fef09ef60be3c1d

(81)

  • M GasCap/readSPIFlash_GasCapAssetTracker/SPIFlash.h <

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-b66d23288e1a738a19d15ac88da45610731149bb42c3f1739a9114e68783fe18

(43)

  • M

GasCap/readSPIFlash_GasCapAssetTracker/readSPIFlash_GasCapAssetTracker.ino

<

https://github.com/kriswiner/CMWX1ZZABZ/pull/35/files#diff-bd0750ed44f6d8c5c076cc3ac93e844ee952b734f1ecc5d3b5e511b48d294ca9

(255)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABTDLKXUSCP7EPUGXKP6EF3XASLOFANCNFSM6AAAAAAWZROGNY

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560321529 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAXDT7TUMFER5SXH5BKWIMTXHVN5BANCNFSM6AAAAAAWZROGNY

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560330211 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABTDLKQLCBKZFSJHQXS7AP3XHVPG3ANCNFSM6AAAAAAWZROGNY

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub <https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560334087 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAXDT7QKEOKL7OOSQBY3KIDXHVP5ZANCNFSM6AAAAAAWZROGNY

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/pull/35#issuecomment-1560347368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTDLKSLBXNKXXM547KERGLXHVSR3ANCNFSM6AAAAAAWZROGNY . You are receiving this because you modified the open/close state.Message ID: @.***>