search

kriswiner / CMWX1ZZABZ

Collection of sketches using the Arduino core for Murata's CMWX1ZZABZ (STM32L082 and SX1276)
94 stars 30 forks source link

No Wire.endTransmission() needed after Wire.requestFrom(). #4

Open Koepel opened 6 years ago

Koepel commented 6 years ago

In the file "CMWX1ZZABZ/LoRaSensorTile/LoRaSensorTile.v05/VEML6040.cpp", in the function "getRGBWdata()" there is a Wire.endTransmission() after the Wire.requestFrom() in line 41 at the moment. That is not needed, it can be removed.

The Wire.endTransmission() should only be use when writing data.

kriswiner commented 6 years ago

Good catch, thanks.

On Sun, Feb 11, 2018 at 9:56 AM, Koepel notifications@github.com wrote:

In the file "CMWX1ZZABZ/LoRaSensorTile/LoRaSensorTile.v05/VEML6040.cpp", in the function "getRGBWdata()" there is a Wire.endTransmission() after the Wire.requestFrom() in line 41 at the moment. That is not needed, it can be removed.

The Wire.endTransmission() should only be use when writing data.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kriswiner/CMWX1ZZABZ/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/AGY1qoBxvHXxEUMvm4Qi9m6MRzjUb3_Vks5tTynegaJpZM4SBbtz .