kriswiner / EM7180_SENtral_sensor_hub

(Affordable) Ultimate Sensor Fusion Solution
https://www.tindie.com/products/onehorse/ultimate-sensor-fusion-solution/
96 stars 37 forks source link

clarification of "Magnetometer and Accelerometer Calibration" doc in wiki #13

Closed seamaster101 closed 6 years ago

seamaster101 commented 6 years ago

I followed the document to the point last night, and believe I got somewhere. I want to point out little inaccuracy (in my opinion), which could be easily corrected. It is related to section "Accelerometer Calibration". in section c. I notice that there is no reference that one should continue to enter 2 with each side calibration. Here it is:


c. Send a “2” over the serial interface to collect the gravity data (in the screenshot above the USFS board is in the Z = +1g condition) and store it to the I2C EEPROM. Re-orient and USFS board for the remaining five conditions and collect/store the gravity data to the I2C EEPROM. The data for all six conditions can be collected and stored as the sketch continues to run. There is no need to re-start the sketch between calibration conditions.


I understand what are you saying but I was confused by the fact that after I entered 2 for the first time, 2 was not an option that I could see offered on the serial monitor. it was prompting for 0 or 1. at this point I decided to enter 2 as I believed that's the right thing to do here so I did enter 2 and it took it, so its all good. I noticed that it increases the number of accelarometer corrections done, therefore I knew I did the right choice to enter 2. My point is that adding little bit to your explanation will remove possible confusion when one is following the otherwise perfect step-by-step instructions. it could read something like: "....Re-orient and USFS board for the remaining five conditions and collect/store the gravity data to the I2C EEPROM by entering 2 in the serial monitor after collecting the data for each of the remaining positions. the serial monitor indicates the number of stored accelerameter corrections. The data for all six conditions can be collected and stored as the sketch continues to run. There is no need to re-start the sketch between calibration conditions."

kriswiner commented 6 years ago

I'll forward your comments to the guy who wrote this section. Thanks for the feedback.

On Wed, Jul 26, 2017 at 7:14 PM, seamaster101 notifications@github.com wrote:

I followed the document to the point last night, and believe I got somewhere. I want to point out little inaccuracy (in my opinion), which could be easily corrected. It is related to section "Accelerometer Calibration". in section c. I notice that there is no reference that one should continue to enter 2 with each side calibration. Here it is:

c. Send a “2” over the serial interface to collect the gravity data (in the screenshot above the USFS board is in the Z = +1g condition) and store it to the I2C EEPROM. Re-orient and USFS board for the remaining five conditions and collect/store the gravity data to the I2C EEPROM. The data for all six conditions can be collected and stored as the sketch continues to run. There is no need to re-start the sketch between calibration conditions.

I understand what are you saying but I was confused by the fact that after I entered 2 for the first time, 2 was not an option that I could see offered on the serial monitor. it was prompting for 0 or 1. at this point I decided to enter 2 as I believed that's the right thing to do here so I did enter 2 and it took it, so its all good. I noticed that it increases the number of accelarometer corrections done, therefore I knew I did the right choice to enter 2. My point is that adding little bit to your explanation will remove possible confusion when one is following the otherwise perfect step-by-step instructions. it could read something like: "....Re-orient and USFS board for the remaining five conditions and collect/store the gravity data to the I2C EEPROM by entering 2 in the serial monitor after collecting the data for each of the remaining positions. the serial monitor indicates the number of stored accelerameter corrections. The data for all six conditions can be collected and stored as the sketch continues to run. There is no need to re-start the sketch between calibration conditions."

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kriswiner/EM7180_SENtral_sensor_hub/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AGY1qnPKjbwa2Pj4Eyg9hJ9N0hGehmVWks5sR_J4gaJpZM4OktZX .