search

kriszyp / lmdb-js

Simple, efficient, ultra-fast, scalable data store wrapper for LMDB
Other
482 stars 39 forks source link

docker build is failing at run npm install command - Build is failing since release of lmdb 2.2.2 #141

Closed santoshtechedge closed 2 years ago

santoshtechedge commented 2 years ago

lmdb@2.2.1 install /app/node_modules/gatsby/node_modules/lmdb node-gyp-build

make: Entering directory '/app/node_modules/gatsby/node_modules/lmdb/build' CXX(target) Release/obj.target/lmdb/src/lmdb-js.o CC(target) Release/obj.target/lmdb/dependencies/lmdb/libraries/liblmdb/midl.o CC(target) Release/obj.target/lmdb/dependencies/lmdb/libraries/liblmdb/chacha8.o CC(target) Release/obj.target/lmdb/dependencies/lz4/lib/lz4.o CXX(target) Release/obj.target/lmdb/src/writer.o CXX(target) Release/obj.target/lmdb/src/env.o CXX(target) Release/obj.target/lmdb/src/compression.o CXX(target) Release/obj.target/lmdb/src/ordered-binary.o CXX(target) Release/obj.target/lmdb/src/misc.o ../src/misc.cpp: In function 'Nan::NAN_METHOD_RETURN_TYPE clearKeptObjects(Nan::NAN_METHOD_ARGS_TYPE)': ../src/misc.cpp:207:28: error: 'class v8::Isolate' has no member named 'ClearKeptObjects' 207 | Isolate::GetCurrent()->ClearKeptObjects(); | ^~~~ make: *** [lmdb.target.mk:145: Release/obj.target/lmdb/src/misc.o] Error 1 make: Leaving directory '/app/node_modules/gatsby/node_modules/lmdb/build' gyp ERR! build error

kriszyp commented 2 years ago

What version of Node are you using? According to the docs that function is supposed to be available in v12, so wondering if you are using an older version or if the docs are wrong.

kriszyp commented 2 years ago

Ah, I see, this was actually added to V8 in NodeJS's minor version v12.16. Sorry about that, I will update the builds accordingly.

kriszyp commented 2 years ago

Should be fixed/published in v2.2.3.