kriszyp / lmdb-js

Simple, efficient, ultra-fast, scalable data store wrapper for LMDB
Other
486 stars 39 forks source link

getRange options have the wrong typescript fields #16

Closed josephg closed 3 years ago

josephg commented 3 years ago

The db.getRange(options) method uses options.limit, options.values and options.versions fields. None of these are present in the corresponding typescript type for RangeOptions:

    interface RangeOptions {
        start?: Key
        end?: Key
        reverse?: boolean
        includeValues?: boolean // Should be values?: boolean
        includeVersions?: boolean // should be versions?: boolean
        // Missing: limit?: number
    }
kriszyp commented 3 years ago

Thanks for the tip! Fixed in 0.8.8.

kriszyp commented 3 years ago

Also, I fixed the referenced weak-lru-cache version so it shouldn't cause loading issues in 0.8.8 as well.

josephg commented 3 years ago

Awesome - much appreciated! So fast!