search

kriszyp / lmdb-js

Simple, efficient, ultra-fast, scalable data store wrapper for LMDB
Other
479 stars 39 forks source link

Update typings #252

Closed zbarbuto closed 11 months ago

zbarbuto commented 11 months ago

The encryptionKey property in the db options didn't seem to exist at all in the typings (nor did eventTurnBatching) - this adds them.

While I was at it, I added the remaining option descriptions as they appear in the readme to the options typings - since some options had them and some didn't. If they were omitted for a reason, happy to remove them and just add the encryptionKey and eventTurnBatching properties.

kriszyp commented 11 months ago

This is great, thank you!

zbarbuto commented 11 months ago

Not a problem - thanks for looking so quickly.

Can I also trouble you for a release of this at some point? I can't see any other changes since the last release and both new fields are optional in the typings so this should be non-breaking.

kriszyp commented 11 months ago

Ok, should be published.