search

kriszyp / lmdb-js

Simple, efficient, ultra-fast, scalable data store wrapper for LMDB
Other
505 stars 41 forks source link

Code formatting for the test suite #254

Closed mindreframer closed 1 year ago

mindreframer commented 1 year ago

I've noticed that the test file is rather sloppily formatted, this makes reading it less convenient.

There were also couple unused imports and skipped tests. Tests are important for database products and formatted code looks a bit more polished. I hope the big diff does not offend anyones feelings. If so, please consider running prettier over this file in another commit and feel free to close this PR.

Thanks for the lib, it's really interesting to play with it. I feel the tests replace the documentation in some areas.

Cheers, Roman

kriszyp commented 1 year ago

This looks very nice, thank you. However, the code style for this repo is tab indentation, could you switch the formatting to using tabs? (I can certainly do that if you don't want to)

mindreframer commented 1 year ago

Hey @kriszyp , sorry for the delay, I was on holidays. I have configured prettier to use tabs and single quotes, hope now it's ok.

kriszyp commented 1 year ago

Thank you!