kriszyp
commented
2 months ago and should even be a little faster.
Can I see how you did your benchmarking? My benchmarking shows that TextDecoder (assume that's what you meant, though it is misspelled), is about 120% slower:
let b = Buffer.alloc(2048);
result = b.write('hello world', 10);
for (let i = 0; i < 10000000; i++){
result = b.toString('utf8', 10, 21); // 55ns in v20/v21
//result = td.decode(Uint8ArraySlice.call(b, 10, 21)); // 125ns in v20, 120ns in v21
//result = td.decode(b.subarray(10, 21)); // 99ns in v20, 94ns in v21
}Sometimes the .toString method does not work properly
Can you provide more details? Is there an issue associated with this?
falcon027
Sometimes the .toString method does not work properly, so I suggest swapping it with the TextEncoder one. The text decoder is a more robust encoder than the .toString method, and should even be a little faster.