calling Object.freeze corrupts null

kriszyp / node-promise

Promise utilities for Node

397 stars 42 forks source link

calling Object.freeze corrupts null #6

Open vpulim opened 13 years ago

vpulim commented 13 years ago

Due to a bug in v8, calling Object.freeze corrupts the global null object. More info: http://groups.google.com/group/nodejs/browse_thread/thread/e205dabc5fcb773e/f578d85ba5da478c

kriszyp commented 13 years ago

Wow, that's a crazy one. Ok, I'll comment out the freeze.

kriszyp commented 13 years ago

Wait, this looks like it is already commented out: https://github.com/kriszyp/node-promise/blob/master/promise.js#L56 Am I missing something?

vpulim commented 13 years ago

oops, sorry, i think we were using an older version of the code. my apologies...

FYI, version 0.3.0 and above of Node uses a version of v8 that fixes that bug. I tested the latest commit of node-promise with node 0.3.4 and un-commented line 56 and it seems to be working fine.