search

kriszyp / put-selector

A high-performance, lightweight function for creating and manipulating DOM elements with succinct, elegant, familiar CSS selector-based syntax
Other
290 stars 39 forks source link

Latest put.js breaks row height in dgrid #10

Closed johnwilander closed 12 years ago

johnwilander commented 12 years ago

I tried going through the dgrid simple tutorial using the latest put-selector and xtype. But I kept getting row height 362px instead of 20px that the online example got. After trying various versions and doing diff on all css files I eventually switched to the put.js used in the tutorial (http://dojofoundation.org/packages/dgrid/tutorials/hello_dgrid/demo/events.html) and suddenly I got the correct row height. It's not obvious which of the code changes in put.js that causes this, especially since I don't know which version is used in the tutorial.

I'd be a happy user if put-selector and xtype had tagged, stable versions. Would that be possible? Thanks!

Regards, John

neonstalwart commented 12 years ago

do you mean tags like put-selector v0.3.0 and xstyle v0.0.5?

kriszyp commented 12 years ago

John, Thank you for letting us know about this. This should be fixed in put-selector master with https://github.com/kriszyp/put-selector/commit/cf47e6eb02c2160cd532cf7a916cddab56aa21a6. Also, as Ben pointed out, there are tags on put-selector and xstyle that you can use. Thanks, Kris

On 8/9/2012 5:53 AM, John Wilander wrote:

I tried going through the dgrid simple tutorial using the latest put-selector and xtype. But I kept getting row height 362px instead of 20px that the online example got. After trying various versions and doing diff on all css files I eventually switched to the put.js used in the tutorial (http://dojofoundation.org/packages/dgrid/tutorials/hello_dgrid/demo/events.html) and suddenly I got the correct row height. It's not obvious which of the code changes in put.js that causes this, especially since I don't know which version is used in the tutorial.

I'd be a happy user if put-selector and xtype had tagged, stable versions. Would that be possible? Thanks!

Regards, John

— Reply to this email directly or view it on GitHub https://github.com/kriszyp/put-selector/issues/10.