search

kriszyp / put-selector

A high-performance, lightweight function for creating and manipulating DOM elements with succinct, elegant, familiar CSS selector-based syntax
Other
290 stars 39 forks source link

-span-span Issues #2

Closed SitePenDavidWalsh closed 13 years ago

SitePenDavidWalsh commented 13 years ago

I was playing around with put-selector and found some weird "-" issues.

The third case makes sense, but the first two cases seem errant.

kriszyp commented 13 years ago

David, Thanks for the report. I fixed the second case with: https://github.com/kriszyp/put-selector/commit/1d2dc5e651d7812c3a71422a78b3bfaec24591bb The first case I think is really a limitation of using a non-standard combinator that is a legal character in tags, classes, and attribute names, and I don't think I can support it. I could try create some special logic, but I don't want to make the parsing more complicated. Thanks, Kris

On 10/11/2011 7:33 PM, David Walsh wrote:

I was playing around with put-selector and found some weird "-" issues.

  • put(existingNode, "-span-span") creates one "span-span" tag
  • put(existingNode, "-span -span") creates only one SPAN tag
  • put(existingNode, "+div+div") creates two DIVs

The third case makes sense, but the first two cases seem errant.