search

kritzcreek / pscid

A lightweight, fast and unintrusive PureScript file-watcher
GNU Lesser General Public License v3.0
133 stars 16 forks source link

Version 2.3.0 on npm seems incomplete #35

Closed Morendil closed 6 years ago

Morendil commented 6 years ago

The version of pscid currently published to the npm registry seems non-functional, it's missing index.js and source files. (I'm unfamiliar with the workings of npm so it took me a while to figure this out and I might still be confused as to what exactly is going on.) Forcing 2.0.2 worked.

kritzcreek commented 6 years ago

Thank you for the report, I'll look into it!

kritzcreek commented 6 years ago

Should be fixed in 2.3.1, could you confirm?

Morendil commented 6 years ago

Hmm, I am seeing an index.js and node can apparently run it, but I get the following error: : No such file or directory

kritzcreek commented 6 years ago

Could you try uninstalling whatever version you have sitting around? I've tried it on two computers now and 2.3.1 works on both....

Morendil commented 6 years ago

This might be an issue with the registry or with packaging, I'm not getting the same results with yarn as I am with npm. My packaging tool of choice is yarn.

Here's what I'm doing:

mkdir pscid-test
docker run --rm -it -v $pwd:/app -w /app node /bin/bash

That is, creating what should amount to a clean system with the latest Node. Then:

yarn add pscid
yarn run pscid

And the result is as before:

yarn run v1.3.2
warning package.json: No license field
$ /app/node_modules/.bin/pscid
: No such file or directory
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Using yarn global add doesn't help.

With yarn add pscid@2.0.2 the install works and I get the following output:

ERROR:
I couldn't find any source directories to watch when trying app/, src/, test/ and tests/.

etc. - this is what I expect.

htmue commented 6 years ago

Same issue on my computer with 2.3.1:

% pscid
env: node\r: No such file or directory

After changing the line endings in index.js from DOS to Unix it works.

kritzcreek commented 6 years ago

Oh my... is it a line ending problem? I'll see if I can fix that.

kritzcreek commented 6 years ago

So I built the 2.4.0 release on a Linux machine instead of Windows, can you check if that fixes things? Thanks!

htmue commented 6 years ago

Yes, that did the trick, thanks a lot! ...and thanks for the very useful tool, btw, I use it every day.

kritzcreek commented 6 years ago

Glad it's working well for you. So I guess I'll have to remember to publish these releases from a Linux machine. Thanks for confirming!

rnons commented 4 years ago

I'm seeing this again on v2.9.0

env: node\r: No such file or directory

Workaround is mentioned in https://github.com/kritzcreek/pscid/issues/35#issuecomment-367631400

After changing the line endings in index.js from DOS to Unix it works.

kritzcreek commented 4 years ago

Sorry I forgot to have to release from Linux. Fixed in v2.9.1 I hope