Ignore state of shift key in keyboard commands

kritzcreek / pscid

A lightweight, fast and unintrusive PureScript file-watcher

GNU Lesser General Public License v3.0

133 stars 16 forks source link

Ignore state of shift key in keyboard commands #51

Closed danieljharvey closed 5 years ago

danieljharvey commented 5 years ago

Hello!

I hope you are well. Thanks for this tool, I use it every day and I have a nice time. Every now and then I think it's broken and doesn't listen to me, and I realised it's because I have the caps lock on, so this PR is an entirely selfish contribution to stop the keyboard commands caring about the state of the shift key so I can avoid footgunning myself several times a day.

Thanks!

i-am-tom commented 5 years ago

As a fellow computer-misuser, I'm happy about this 👌

i-am-tom commented 5 years ago

Having a second look, could we just remove the , shift: _ from the pattern-match entirely?

danieljharvey commented 5 years ago

Aye, would probably make things cleaner.

kritzcreek commented 5 years ago

Thanks, removed the shift pattern matches in bf90dd733ff5f346b3ef28953644a79e0e455768

kritzcreek commented 5 years ago

Released as 2.7.0