search

kritzcreek / purescript-psc-ide

PureScript client for psc-ide
MIT License
9 stars 11 forks source link

Start server with args #17

Closed nwolverson closed 8 years ago

nwolverson commented 8 years ago

(This is on top of the position info change)

Thoughts on startServer overloads?

kritzcreek commented 8 years ago

Since we already have a configuration object, I think we should extend it to also take the STDIOBehaviour and exe path. I think the only three current users are you, @anttih and me, so I'd prefer to go for a clean API and accept breaking changes.

kritzcreek commented 8 years ago

I rebased instead of merging on master, so you'll have to rebase this one aswell, sry..

nwolverson commented 8 years ago

Sure, I was thinking of it as an object representing the arguments in a typed way - but no real reason to do so.

Do you think we should just go with a single startServer taking such an object?

kritzcreek commented 8 years ago

@nwolverson exactly, and have the default behaviour for ' and '' inside the default configuration object

kritzcreek commented 8 years ago

sold!

nwolverson commented 8 years ago

Thanks :+1: