search

kritzcreek / purescript-psc-ide

PureScript client for psc-ide
MIT License
9 stars 11 forks source link

Upgrade argonaut dependency #49

Closed thomashoneyman closed 4 years ago

thomashoneyman commented 4 years ago

The most recent major release of the Argonaut library introduces typed errors. This PR updates this library for compatibility.

This library will need a new release to stay compatible with the next package set, as tracked by this issue: https://github.com/purescript/package-sets/issues/642

Sorry for the hassle! Thanks!

thomashoneyman commented 4 years ago

The test failure is because I didn't update the psc-package file. However, when the next package set comes out (in the next week or so) the psc-package file could be updated to point at that set instead. Let me know how you'd like to handle this and I can do my part to help out!

kritzcreek commented 4 years ago

Sorry for the hassle

No worries, giving argonaut typed errors is a great change!

Let me know how you'd like to handle this

Whichever is less of a hassle for you. Eventually we'll want to move this library to spago (I think the editor plugins for vscode and the language server have already done so), but just keeping CI running with psc-package after the next packaget-set is good enough for me. Let's just make sure to open an issue on this repo so I don't forget.

thomashoneyman commented 4 years ago

OK, this is super weird -- it's failing to build the argonaut-codecs dependency because generics-rep is missing. But argonaut-codecs depends on generics-rep and builds fine in all the other projects I've been testing. I'm not sure what's going on. It also builds fine if I install generics-rep in this library, but that shouldn't be necessary.

kritzcreek commented 4 years ago

Sorry I'm kind of swamped at work, so don't have the time to help debug this right now.

thomashoneyman commented 4 years ago

I was wrong and this was an introduced dependency after all. I've indicated that in the overrides -- when the next package set is released the overrides can be removed.

I'm not sure why the CI build status isn't showing up on GitHub, but you can see that the build does pass now: https://travis-ci.org/github/kritzcreek/purescript-psc-ide

kritzcreek commented 4 years ago

Thanks, looking good.

kritzcreek commented 4 years ago

Released as v16.0.0