search

kritzware / json.pizza

Online JSON formatter and prettifier
https://json.pizza
80 stars 15 forks source link

Change Ctrl to Cmd on macOS machines #13

Closed rijkvanzanten closed 4 years ago

rijkvanzanten commented 5 years ago

Hey there!

I often use https://json.pizza to quickly format some JSON snippets before sending them elsewhere (Slack etc), but kept hitting Cmd+Enter instead of Ctrl+Enter.

Ctrl isn't really used as a modifier in apps and websites on a Mac; Cmd is.

This PR adds support for using Cmd for macOS users.

Keep on rockin'!

rijkvanzanten commented 4 years ago

@kritzware Anything you need changed or updated before it's ready to merge?

kritzware commented 4 years ago

Hey there @rijkvanzanten, thanks for this awesome PR!

Apologies for the delay. Everything looks good, so I'm going to go ahead and merge it in. It should be automatically deployed by Netlify within a few minutes of merging.

🎉

rijkvanzanten commented 4 years ago

No worries!

From my own experience with GitHub, it can be very easy to lose track of these kind of PRs in not often used repos, especially when they aren't in notifications anymore, so my comment was also a secret "bump" 😋

kritzware commented 4 years ago

Very true! Any future PR's also welcome 😄