search

krizalys / onedrive-php-sdk

OneDrive SDK for PHP
BSD 3-Clause "New" or "Revised" License
144 stars 66 forks source link

Updated type of webUrl to string #85

Closed wimwinterberg closed 4 years ago

wimwinterberg commented 4 years ago

Updated the type hint of web url

Using phpstan or phan results in a error/warning

codecov-commenter commented 4 years ago

Codecov Report

Merging #85 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
  Complexity      498      498           
=========================================
  Files            54       54           
  Lines          1804     1804           
=========================================
  Hits           1168     1168           
  Misses          636      636
Impacted Files Coverage Δ Complexity Δ
src/Proxy/BaseItemProxy.php 100.00% <ø> (ø) 18.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f87c68...141396b. Read the comment docs.

krizalys commented 4 years ago

Good catch. Thanks for the fix.