search

krkn-chaos / cerberus

Guardian of Kubernetes clusters. Tool to monitor clusters health and signal/alert on failures.
Apache License 2.0
92 stars 41 forks source link

Adding csr conditions #141

Closed paigerube14 closed 3 years ago

paigerube14 commented 3 years ago

Description

This code is to get around a bug but would also be a useful check to verify the certain conditions of a csr's status exists as expected.

Fixes

https://github.com/cloud-bulldozer/cerberus/issues/138

comet-perf-ci commented 3 years ago

Can one of the admins verify this patch?

mffiedler commented 3 years ago

LGTM

chaitanyaenr commented 3 years ago

/rerun all

chaitanyaenr commented 3 years ago

@paigerube14 Looks like the linters are failing because of the allowed char length unrelated to this commit, we might want to bump the chars allowed per line to 120 since that's reasonable I guess. Thoughts?

comet-perf-ci commented 3 years ago
Test Result Duration
test_daemon_disabled Pass 00:00:28
test_detailed_data_inspection Pass 00:00:49
test_slack_integration Pass 00:01:04
Check Gold time (s) PR time (s) % Change
"check_master_taint" .204565 .183275 -10.40
"entire_iteration" 3.212999 3.063104 -4.66
"sleep_tracker" 1.137242 1.055927 -7.15
"watch_cluster_operators" .509025 .514962 1.16
"watch_csrs" .125803 .124394 -1.12
"watch_namespaces" 1.119676 1.071303 -4.32
"watch_nodes" .192552 .198699 3.19