search

krlawrence / graph

Practical Gremlin - An Apache TinkerPop Tutorial
Apache License 2.0
836 stars 253 forks source link

Replaced deprecated sorting parameters #196

Closed ghost closed 4 years ago

ghost commented 4 years ago

Replaced all references to the order parameters incr and decr with asc and desc in the "Sorting things - introducing order" section. According to the TinkerPop Documentation Order Step, this is the preferred method as of version 3.3.4. I've only replaced these parameters in this single section, but I'll modify any others I come across.

ghost commented 4 years ago

Closed this pull request as these changes to order are mentioned further on in the book. I personally feel that deprecated methods should not be taught and a simple mention of previous syntax is more appropriate, however the topic is subjective. This is an awesome resource for learning TinkerPop. Thanks for the effort.

krlawrence commented 4 years ago

Thanks for taking the time to provide feedback and changes. I do plan to make a global pass on things like this at some point. My hesitation has been mostly due to wide the range of supported TinkerPop levels across different graph databases. There are a lot of queries out there using the prior syntax and I want people encountering it to know what it means. My thinking here is that at some point I should flip things around so that the Note in the book talks about the old way and all the examples reflect the new way.