search

krlmlr / r-appveyor

Tools for using R with AppVeyor (https://appveyor.com)
132 stars 60 forks source link

USE_RTOOLS implicitly set to true if required? #111

Closed wibeasley closed 5 years ago

wibeasley commented 6 years ago

In the same way that USE_RTOOLS is essentially set to true if there's a src/ directory, would it make sense to automatically install Rtools if the AppVeyor script tried to run - travis-tool.sh install_github qqq/mmm?

If not, is there a benefit in throwing a warning along the lines of this?

Warning, r-appveyor is attempting to install a package from source, without first installing Rtools. Consider setting USE_RTOOLS=true in appveyor.yml after consulting the documentation at https://github.com/krlmlr/r-appveyor/.

The existing documentation is very clear, but I still overlooked it tonight, and it appears that a few other people have made the same oversight:

hughjonesd commented 6 years ago

Me too on this. I could try for a PR?

krlmlr commented 6 years ago

Do we always need Rtools when installing from GitHub?

@jimhester: Would you consider an "install Rtools if needed" option for pkginstall::install_*()? AppVeyor would be its only legitimate user, though...

jimhester commented 6 years ago

You only need Rtools if the dependencies you are installing need compiled code

Using pkgdepends we will be able to tell before installation if any of your dependencies need compiled code, because it resolves all dependencies prior to beginning installation. So once that is working it should not be hard to have appveyor automatically install Rtools if needed.

krlmlr commented 5 years ago

Closing for now, we have PKGTYPE=win.binary by default which should resolve most of the pain points.