krlmlr / r-appveyor

Tools for using R with AppVeyor (https://appveyor.com)
132 stars 60 forks source link

issues with install_github? #33

Closed jordansread closed 8 years ago

jordansread commented 9 years ago

Hi @krlmlr thank you so much for your support of r-appveyor.

We are running into a new issue with install_github for package dependencies:

for R-unstable: https://ci.appveyor.com/project/jread-usgs/mda-streams/build/0.1.183#L140 and R-stable (3.2.0) https://ci.appveyor.com/project/jread-usgs/mda-streams/build/0.1.179#L309

Do you know if this is a devtools issue or part of appveyor permissions that may have changed?

Thanks

krlmlr commented 9 years ago

Hi @jread-usgs

Thanks for reporting this. It looks like AppVeyor has hit some limit on GitHub. Please ping me if the problem doesn't disappear tomorrow.

maelle commented 8 years ago

So is this supposed to happen from time to time because of GitHub limits for AppVeyor? I encountered a similar issue today.

Thanks anyway for the repo. :-)

gaborcsardi commented 8 years ago

@masalmon Yes, you can work around this by getting a GitHub token, and then adding it to Appveyor as a secret GITHUB_PAT environment variable.

maelle commented 8 years ago

Thanks a lot @gaborcsardi ! This was very helpful! I'll write the steps in a dumb-proof way (I'm the dumb tester :-) ) for future reference:

krlmlr commented 8 years ago

Does it also work if you set GITHUB_PAT in the AppVeyor web interface?

maelle commented 8 years ago

@krlmlr where exactly in the AppVeyor web interface?

krlmlr commented 8 years ago

Settings -> Environment -> Add variable

maelle commented 8 years ago

Ok this makes sense, sorry, I thought it would be a global thing. If I did this I would still have to add the variable for each project, so it would not be a real gain compared to having the variable in appveyor.ylm, would it?

krlmlr commented 8 years ago

GitHub's PAT is personal, and you probably want to encrypt it -- you'll have to add it for each repo anyway.

maelle commented 8 years ago

Yes which is what I do now (putting the encrypted PAT in all my appveyor.yml). You mean the gain of adding it via the interface simply is the fact that I wouldn't have to encrypt it?

krlmlr commented 8 years ago

IMO, the gain is that you don't pollute the .yml, but I'm not sure if this is really simpler than editing appveyor.yml once for all projects. Anyway, I've added an external GITHUB_PAT to one of my projects, if I ever hit the rate limit with this, we know it doesn't work.

maelle commented 8 years ago

Ok, thanks!